refactor(tests): fix few tests, use pytest.raises, extend raises helper #500
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I thought it would be nice to modernize tests a bit:
with pytest.raises()
orwith raises()
in multiple placesraises()
manager throw AssertionError if expected exception was not raised inside the contextI have some doubts regarding existing tests if they really test what they say they do, especially
test_self_any
andtest_self_all
. However it should be checked by someone with more experience (I haven't usedSelf
-related validation yet myself)