-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python_requires so package installers know this requires 3.7 or newer #494
Conversation
…ewer Also remove some stale classifiers
@alecthomas - awesome, thanks. Now can I nag you for a voluptuous 0.14.1 release? |
I just published a new release |
Thanks Philip, appreciate it! |
@spacegaier - any chance you could yank the 0.14.0 release? Colleagues have pointed out that pip will still pick it on Python 2 and 3.6 :-/ |
Does that have any side effects e.g. for people that already pulled that version? Never had to yank a version on PyPi. Would need to read up on how to do that to begin with... |
I don't think that would be a good idea would it? Anyone depending on that release will have their build broken. |
I mean, not yanking it means every Python 3.6 or earlier user still has to deal with this bug forever more with ugly workarounds. I'm not 100% sure of the semantics of yanking, it may leave the release up there for those explicitly requesting it, but even if not, it doesn't feel like a third point upgrade to fix broken built is a bad trade off for every 3.6 and earlier user having to cargo cult a workaround in their package config. |
I don't think that logic holds does it? If they're on 3.6 it would never have worked and they wouldn't have pinned it, and if they're not pinned they'll get the next version. |
Ah I see what you're saying. It's because it's the last version valid for 3.6/2.7. |
Yep, currently breaking CI for a handful of internal packages where they work, ;cos 2.7 or 3.6 versions are picking up 0.14.0 and blowing up |
Yanked it. PyPi says it's still usable if pinned, so that's good. |
Many thanks! :-) |
Also remove some stale classifiers.
Happy to add any release notes or whatever to get a release out.