Remove value enumeration when validating empty list #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. so that you can e.g. run `tox -- --pdb` to get a debugger on test failures.
The behaviour seems to have been introduced in commit 95489bd that modified the schema of an empty list in order to provide a consistent behaviour between Schema({}) and Schema([]). The commit introduced an enumeration of the incorrect values rather than the expected behaviour of showing the key with the incorrect value. This commit provides the expected behaviour, and is also consistent with the 'pathless' behaviour currently implemented, meaning that - Schema([])([1]) -> 'not a valid value @ data[1]' - Schema({'key': []})({'key': [1]) -> 'not a valid dictionary value @ data['key']. Finally, as new unit test is provided to ensure that the new behaviour remains intact.
1 similar comment
spacegaier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behaviour seems to have been introduced in commit
95489bd that modified the schema of an empty list in order
to provide a consistent behaviour between Schema({}) and Schema([]).
The commit introduced an enumeration of the incorrect values rather
than the expected behaviour of showing the key with the incorrect
value.
This commit provides the expected behaviour, and is also consistent
with the 'pathless' behaviour currently implemented, meaning that
Finally, as new unit test is provided to ensure that the new behaviour
remains intact.