Preserve Unicode strings when passed to utility functions #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
reviewed
Dec 31, 2018
voluptuous/util.py
Outdated
| @@ -14,7 +16,11 @@ def Lower(v): | |||
| >>> s('HI') | |||
| 'hi' | |||
| """ | |||
| return str(v).lower() | |||
| if _PY2 and isinstance(v, unicode): | |||
There was a problem hiding this comment.
Maybe replace this repeated fragment with a mini helper function? _fix_str(v) or something?
|
One minor comment but overall LGTM 👍 |
|
Also, happy New Year! |
This updates the string utility functions to return a Unicode string when a Unicode string is passed in. In Python 2 this would raise an error due to the use of str(v). This is a change related to issue alecthomas#374. The tests also check for other types (int) to preserve existing functionality.
svisser
force-pushed
the
fix/issue_374
branch
from
c8be8f1 to
2f8412a
Compare
|
That's fair, I have updated the commit - with the Python 2 check inlined as we hopefully won't need it anymore when Python 2 reaches end of life at the end of next year ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, best wishes for 2019.
This updates the string utility functions to return a Unicode string when a Unicode string is passed in. In Python 2 this would raise an error due to the use of str(v).
This is a change related to issue #374.
The tests also check for other types (int) to preserve existing functionality.