Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a discrminant field in validators #368

Merged
merged 5 commits into from
Aug 15, 2019
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion voluptuous/tests/tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
Replace, Range, Coerce, All, Any, Length, FqdnUrl, ALLOW_EXTRA, PREVENT_EXTRA,
validate, ExactSequence, Equal, Unordered, Number, Maybe, Datetime, Date,
Contains, Marker, IsDir, IsFile, PathExists, SomeOf, TooManyValid, Self,
raises)
raises, Union)
from voluptuous.humanize import humanize_error
from voluptuous.util import u, Capitalize, Lower, Strip, Title, Upper

Expand Down Expand Up @@ -1406,3 +1406,27 @@ def test_exclusive():
"two or more values in the same group of exclusion 'stuff' @ data[<stuff>]")
else:
assert False, "Did not raise Invalid for multiple values in Exclusive group"

def test_any_with_discriminant():
schema = Schema({
'implementation': Union({
'type': 'A',
'a-value': str,
}, {
'type': 'B',
'b-value': int,
}, {
'type': 'C',
'c-value': bool,
}, discriminant=lambda value, alternatives: filter(lambda v : v['type'] == value['type'], alternatives))
})
try:
schema({
'implementation': {
'type': 'C',
'c-value': None,}
})
except MultipleInvalid as e:
assert_equal(str(e),'expected bool for dictionary value @ data[\'implementation\'][\'c-value\']')
else:
assert False, "Did not raise correct Invalid"
53 changes: 53 additions & 0 deletions voluptuous/validators.py
Original file line number Diff line number Diff line change
Expand Up @@ -193,15 +193,23 @@ def __init__(self, *validators, **kwargs):
self.validators = validators
self.msg = kwargs.pop('msg', None)
self.required = kwargs.pop('required', False)
self.discriminant = kwargs.pop('discriminant', None)

def __voluptuous_compile__(self, schema):
self._compiled = []
self.schema = schema
for v in self.validators:
schema.required = self.required
self._compiled.append(schema._compile(v))
return self._run

def _run(self, path, value):
if self.discriminant is not None:
self._compiled = [
self.schema._compile(v)
for v in self.discriminant(value, self.validators)
]

return self._exec(self._compiled, value, path)

def __call__(self, v):
Expand Down Expand Up @@ -262,6 +270,51 @@ def _exec(self, funcs, v, path=None):
# Convenience alias
Or = Any

class Union(_WithSubValidators):
"""Use the first validated value among those selected by discrminant.

:param msg: Message to deliver to user if validation fails.
:param discriminant: Function to filter the values
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move the signature description into this param comment please.

:param kwargs: All other keyword arguments are passed to the sub-Schema constructors.
:returns: Return value of the first validator that passes.

discriminant(value, validators) is invoked in execution.

>>> validate = Schema(Union({'type':'a', 'a_val':'1'},{'type':'b', 'b_val':'2'},
... discriminant=lambda val, alt: filter(
... lambda v : v['type'] == val['type'] , alt)))
>>> validate({'type':'a', 'a_val':'1'}) == {'type':'a', 'a_val':'1'}
True
>>> with raises(MultipleInvalid, "not a valid value for dictionary value @ data['b_val']"):
... validate({'type':'b', 'b_val':'5'})

```discriminant({'type':'b', 'a_val':'5'}, [{'type':'a', 'a_val':'1'},{'type':'b', 'b_val':'2'}])``` is invoked

Without the discriminant, the exception would be "extra keys not allowed @ data['b_val']"
"""

def _exec(self, funcs, v, path=None):
error = None
for func in funcs:
try:
if path is None:
return func(v)
else:
return func(path, v)
except Invalid as e:
if error is None or len(e.path) > len(error.path):
error = e
else:
if error:
raise error if self.msg is None else AnyInvalid(
self.msg, path=path)
raise AnyInvalid(self.msg or 'no valid value found',
path=path)


# Convenience alias
Switch = Union


class All(_WithSubValidators):
"""Value must pass all validators.
Expand Down