Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix validators.Date behaviour when a custom format is specified #351

Merged
merged 1 commit into from
Jul 19, 2018
Merged

fix validators.Date behaviour when a custom format is specified #351

merged 1 commit into from
Jul 19, 2018

Conversation

entropiae
Copy link
Contributor

@entropiae entropiae commented Jul 18, 2018 •
edited
Loading

Fixes #339

As a side effect of the fix, the validator now considers non-zero-padded days and months as valid. I hope this is fine.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 95.349% when pulling 7d17304 on entropiae:master into 6cd3b1d on alecthomas:master.

1 similar comment
@coveralls
Copy link

coveralls commented Jul 18, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 95.349% when pulling 7d17304 on entropiae:master into 6cd3b1d on alecthomas:master.

@alecthomas alecthomas merged commit 7dbbd05 into alecthomas:master Jul 19, 2018
@alecthomas
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Date validator fails if len(input_string) != 10
3 participants
@entropiae @coveralls @alecthomas