Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Equal validator #200

Merged
merged 1 commit into from
Sep 11, 2016

Conversation

tuukkamustonen
Copy link
Contributor

@tuukkamustonen tuukkamustonen commented Sep 11, 2016

Adds a validator for matching equal values, e.g. Equal([]). Saves you from typing All(list, Length(max=0)). Or maybe do Equal({}) when you have extra=True.

@tusharmakkar08 tusharmakkar08 merged commit bf0ce8e into alecthomas:master Sep 11, 2016
@tusharmakkar08
Copy link
Collaborator

Merged 🍰
Can you please also update the documentation in branch gh-pages ?

@tuukkamustonen tuukkamustonen deleted the equal-validator branch September 12, 2016 05:48
@tuukkamustonen
Copy link
Contributor Author

@tusharmakkar08 I can, but what do you want me to put there? Equal will be auto-included into the validators page, afaik.

@tusharmakkar08
Copy link
Collaborator

@tuukkamustonen : Yes, but you need to remake the documentation after pulling from master. Also create the PR for the same.

@tuukkamustonen
Copy link
Contributor Author

@tusharmakkar08 Sorry, I'm not familiar with gh-pages.

Should I make a dummy commit and PR? Or merge master to gh-pages and PR? Or rebase on master (that would require force push I guess)?

@alecthomas
Copy link
Owner

@tuukkamustonen It might be an idea to create a Wiki page describing how to update the documentation, then we can point contributors to it.

@tusharmakkar08
Copy link
Collaborator

@tuukkamustonen : Just merge the master into gh-pages and then follow this: https://github.com/alecthomas/voluptuous/tree/gh-pages#contribution-to-documentation. Let me know if you still face any issue.
Yes, we can create a Wiki page for describing how to update the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants