lexers: move to comparing bytes in tests #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures we consistently write a trailing newline when RECORD=true is set.
This is the mechanical result of running:
RECORD=true go test ./lexers
This helps to ensure that running RECORD=true go test ./lexers on a
given commit for which the tests pass will not result in any changes in
the working tree.
Notes that as a result of this change, the following command results in
a clean working tree:
RECORD=true go test ./lexers
Fixes alecthomas#855
|
I don't think your analysis is correct. As far as I can tell (edit) |
|
. |
|
Sorry, early morning brain fart 🤦 , I changed my mind. Let's merge it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for comments on each change, but in summary:
RECORD=truelexers/lexers_test.goto compare for byte equality to ensure that the working tree of a commit where the tests pass is left in a clean state when run withRECORD=trueNote that as a result of this change, the following command results in a clean working tree:
Fixes #855