Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #11 from alcole/main #12

Merged
merged 6 commits into from
Sep 17, 2024
Merged

Merge pull request #11 from alcole/main #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
71300b3
removed warning reason in test cases
alcole Sep 17, 2024
2479e60
Merge branch 'data-bristol-demo' of https://github.com/alcole/databri…
alcole Sep 17, 2024
901402c
Merge pull request #11 from alcole/main
alcole Sep 17, 2024
7f43974
Merge branch 'data-bristol-demo' of https://github.com/alcole/databri…
alcole Sep 17, 2024
4bcc018
added whitespace to transforms from lint warning
alcole Sep 17, 2024
e85fde6
Updated pylint badge
github-actions[bot] Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[![linting: pylint](https://img.shields.io/badge/linting-pylint-yellowgreen)](https://github.com/pylint-dev/pylint)
![pylint](https://img.shields.io/badge/PyLint-5.71-orange?logo=python&logoColor=white)
![pylint](https://img.shields.io/badge/PyLint-6.43-orange?logo=python&logoColor=white)
# databricks-best-practices
![databricks logo](https://upload.wikimedia.org/wikipedia/commons/6/63/Databricks_Logo.png)

Expand Down
2 changes: 1 addition & 1 deletion covid_analysis/transforms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ def clean_spark_cols(pdf):
# Convert index to column (works with pandas API on Spark, too).
def index_to_col(df, colname):
df[colname] = df.index
return df
return df
2 changes: 1 addition & 1 deletion tests/transforms_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def test_filter(raw_input_df):
# The test data has NaNs for Daily ICU occupancy; this should get filled to 0.
def test_pivot(raw_input_df):
pivoted = pivot_and_clean(raw_input_df, 0)
assert pivoted["Daily ICU occupancy"][0] == 0
assert pivoted["Daily ICU occupancy"].iloc[0] == 0

# Test column cleaning.
def test_clean_cols(colnames_df):
Expand Down