Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

handles multiple lookup field values #5112

Merged
merged 34 commits into from
Jan 30, 2024
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
6faf18c
provisions to identify fields with multiple value
HiteshRepo Jan 24, 2024
fa4ea5b
handles multiple persons list items
HiteshRepo Jan 24, 2024
26c957d
handles multiple lookup field values
HiteshRepo Jan 24, 2024
b770d02
fix test TestColumnDefinitionable_LegacyColumns
HiteshRepo Jan 24, 2024
573686c
Merge remote-tracking branch 'origin/lists-multiple' into person-mult…
HiteshRepo Jan 24, 2024
7c22a0a
Merge remote-tracking branch 'origin/person-multiple' into lookup-mul…
HiteshRepo Jan 24, 2024
43c678d
updates function name that sets multiple enabled by data type
HiteshRepo Jan 25, 2024
265ef59
resolves conflicts with lists-multiple
HiteshRepo Jan 25, 2024
162d32e
updates function name that sets multiple enabled by data type
HiteshRepo Jan 25, 2024
ea7c988
fix merge conflicts
HiteshRepo Jan 25, 2024
feedafe
Merge remote-tracking branch 'origin/person-multiple' into lookup-mul…
HiteshRepo Jan 25, 2024
e2f2732
skips setting odatatype for text columns
HiteshRepo Jan 25, 2024
5daae6f
merge conflicts with lists-multiple
HiteshRepo Jan 25, 2024
3d77b56
resolve conflicts with person-multiple
HiteshRepo Jan 25, 2024
98b7e5e
fix lint
HiteshRepo Jan 25, 2024
00f1405
resolve conflicts with base
HiteshRepo Jan 25, 2024
8cb30e6
Merge remote-tracking branch 'origin/person-multiple' into lookup-mul…
HiteshRepo Jan 25, 2024
01a524f
simplifies logic to distinguish namings
HiteshRepo Jan 25, 2024
9aa1ae7
resolve conflicts with base
HiteshRepo Jan 25, 2024
aac0d39
fix test TestColumnDefinitionable_LegacyColumns
HiteshRepo Jan 25, 2024
9b8aa6c
Merge remote-tracking branch 'origin/person-multiple' into lookup-mul…
HiteshRepo Jan 25, 2024
abdf620
Merge remote-tracking branch 'origin/main' into lists-multiple
HiteshRepo Jan 29, 2024
0c7572e
updates comment for colDetails names
HiteshRepo Jan 29, 2024
5774003
Merge remote-tracking branch 'origin/lists-multiple' into person-mult…
HiteshRepo Jan 29, 2024
20cee12
fixes nit
HiteshRepo Jan 29, 2024
fa4a6ca
Merge remote-tracking branch 'origin/person-multiple' into lookup-mul…
HiteshRepo Jan 29, 2024
55aed0d
address review comment
HiteshRepo Jan 29, 2024
193d1d3
address review comments
HiteshRepo Jan 29, 2024
9177702
address review comments
HiteshRepo Jan 29, 2024
75a13fb
fix type cast
HiteshRepo Jan 29, 2024
d250d72
Merge remote-tracking branch 'origin/person-multiple' into lookup-mul…
HiteshRepo Jan 29, 2024
7346d54
resolve conflicts with main
HiteshRepo Jan 30, 2024
65602ba
Merge remote-tracking branch 'origin/person-multiple' into lookup-mul…
HiteshRepo Jan 30, 2024
0485c51
resolve merge conflicts with main
HiteshRepo Jan 30, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixes nit
HiteshRepo committed Jan 29, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 20cee12cd7349d56dbd73d357d5915ae5358a756
2 changes: 1 addition & 1 deletion src/pkg/services/m365/api/lists.go
Original file line number Diff line number Diff line change
@@ -620,7 +620,7 @@ func specifyODataType(filteredData map[string]any, colDetails *columnDetails, co
}

switch {
case colDetails.isPersonColumn || colDetails.isLookupColumn:
case colDetails.isPersonColumn, colDetails.isLookupColumn:
filteredData[colName+ODataTypeFieldNamePart] = ODataTypeFieldNameIntVal
default:
filteredData[colName+ODataTypeFieldNamePart] = ODataTypeFieldNameStringVal