Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

add teams chats selectors boilerplate #5075

Merged
merged 2 commits into from
Jan 25, 2024
Merged

add teams chats selectors boilerplate #5075

merged 2 commits into from
Jan 25, 2024

Conversation

ryanfkeepers
Copy link
Contributor

standard boilerplate additions, largely copy-paste and renamed from other files.

Does this PR need a docs update or release note?

  • ⛔ No

Type of change

  • 🌻 Feature

Issue(s)

Test Plan

  • ⚡ Unit test

@ryanfkeepers ryanfkeepers added the chats 1:1 chats within teams label Jan 19, 2024
@ryanfkeepers ryanfkeepers self-assigned this Jan 19, 2024
@aviator-app Aviator app
Copy link
Contributor

aviator-app bot commented Jan 19, 2024 •
edited
Loading

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

pandeyabs
pandeyabs approved these changes Jan 23, 2024
View reviewed changes
src/pkg/backup/details/teamsChats.go Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been using foo_bar.goconvention for file names. Can we change name to teams_chats.go?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

punting: I'll come back to this at the end of all the PRs to minimize churn.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

src/pkg/selectors/teamsChats.go Show resolved Hide resolved
src/pkg/selectors/teamsChats.go Outdated Show resolved Hide resolved
src/pkg/selectors/teamsChats.go Show resolved Hide resolved
src/pkg/selectors/teamsChats.go Outdated Show resolved Hide resolved
@ryanfkeepers
add teams chats selectors boilerplate
dbdfdd2 
standard boilerplate additions, largely copy-paste and renamed from other files.
@ryanfkeepers
linter, unit test fixes
6dce5bb
@ryanfkeepers ryanfkeepers force-pushed the 5061-chats-service-boilerplate-3 branch from 41dd358 to 6dce5bb Compare January 25, 2024 19:06
@ryanfkeepers ryanfkeepers merged commit e90fef4 into 5061-chats-service-boilerplate-2 Jan 25, 2024
4 of 6 checks passed
@ryanfkeepers ryanfkeepers deleted the 5061-chats-service-boilerplate-3 branch January 25, 2024 19:06
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pandeyabs pandeyabs mentioned this pull request Jan 25, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pandeyabs pandeyabs pandeyabs approved these changes

@HiteshRepo HiteshRepo Awaiting requested review from HiteshRepo

Assignees

@ryanfkeepers ryanfkeepers

Labels
chats 1:1 chats within teams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanfkeepers @pandeyabs