Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pool): add tests for da/gas limit in pool #877

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

dancoombs
Copy link
Collaborator

@dancoombs dancoombs commented Oct 21, 2024

Closes: #858, #845

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 107 lines in your changes missing coverage. Please review.

Project coverage is 58.73%. Comparing base (868a118) to head (f57a98b).
Report is 1 commits behind head on feat/v0.4.

Files with missing lines Patch % Lines
crates/provider/src/alloy/da/mod.rs 0.00% 105 Missing ⚠️
crates/pool/src/mempool/uo_pool.rs 99.35% 1 Missing ⚠️
crates/provider/src/alloy/da/local/bedrock.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/builder/src/bundle_proposer.rs 90.14% <100.00%> (+2.31%) ⬆️
crates/pool/src/mempool/pool.rs 96.56% <100.00%> (+6.19%) ⬆️
crates/provider/src/traits/test_utils.rs 100.00% <100.00%> (ø)
crates/pool/src/mempool/uo_pool.rs 92.61% <99.35%> (+2.66%) ⬆️
crates/provider/src/alloy/da/local/bedrock.rs 0.00% <0.00%> (ø)
crates/provider/src/alloy/da/mod.rs 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

Flag Coverage Δ
unit-tests 58.73% <80.00%> (+0.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 63.37% <100.00%> (+1.38%) ⬆️
dev ∅ <ø> (∅)
pool 66.73% <99.67%> (+2.35%) ⬆️
provider 20.87% <22.62%> (+0.46%) ⬆️
rpc 25.87% <ø> (ø)
sim 76.65% <ø> (ø)
tasks ∅ <ø> (∅)
types 67.83% <ø> (+0.31%) ⬆️
utils 29.38% <ø> (ø)

Comment on lines +151 to 152
.map_err(|e| error!("failed to check if fjord: {:?}", e))
.unwrap_or(false)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: should check this, if this ever errors we actually have an assert!() in it that causes panics. Not sure if that gets included in our builds or not.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will look into this in another PR as this is not related to the tests (just added the log)

@dancoombs dancoombs force-pushed the danc/pool-gas-tests branch from 9220c5f to f57a98b Compare October 22, 2024 21:18
@andysim3d andysim3d self-requested a review October 22, 2024 21:32
@dancoombs dancoombs merged commit 0f7c787 into feat/v0.4 Oct 22, 2024
10 checks passed
@dancoombs dancoombs deleted the danc/pool-gas-tests branch October 22, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants