-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pool): add tests for da/gas limit in pool #877
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 2 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
.map_err(|e| error!("failed to check if fjord: {:?}", e)) | ||
.unwrap_or(false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: should check this, if this ever errors we actually have an assert!()
in it that causes panics. Not sure if that gets included in our builds or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will look into this in another PR as this is not related to the tests (just added the log)
9220c5f
to
f57a98b
Compare
Closes: #858, #845