fix: [S6][ALCHEMY-010] uninstall revert on inconsistent config #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jaypaik
commented
Nov 22, 2024
| error Erc4337FunctionNotAllowed(bytes4 selector); | ||
| error ExecutionFunctionAlreadySet(bytes4 selector); | ||
| error ExecutionFunctionNotSet(bytes4 selector); | ||
| error ExecutionHookNotSet(HookConfig hookConfig); |
There was a problem hiding this comment.
Consistent with
jaypaik
force-pushed
the
11-22-fix_alchemy-010_easy_fixes_002_015_016_
branch
from
f0f63f8 to
42526f8
Compare
jaypaik
force-pushed
the
11-22-fix_s6_alchemy-010_uninstall_revert_on_inconsistent_config
branch
from
46a7ee4 to
5c6149c
Compare
Base automatically changed from
11-22-fix_alchemy-010_easy_fixes_002_015_016_
to
develop
November 23, 2024 06:16
jaypaik
force-pushed
the
11-22-fix_s6_alchemy-010_uninstall_revert_on_inconsistent_config
branch
from
5c6149c to
4e13dd0
Compare
Summary by OctaneNew ContractsNo new contracts were added in this PR. Updated Contracts
🔗 Commit Hash: 4e13dd0 |
|
Contract sizes: | Contract | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
|-------------------------------|------------------|-------------------|--------------------|---------------------|
| AccountFactory | 6,121 | 6,595 | 18,455 | 42,557 |
| AllowlistModule | 9,553 | 9,580 | 15,023 | 39,572 |
-| ExecutionInstallDelegate | 5,667 | 5,713 | 18,909 | 43,439 |
-| ModularAccount | 22,401 | 29,200 | 2,175 | 19,952 |
+| ExecutionInstallDelegate | 5,947 | 5,993 | 18,629 | 43,159 |
+| ModularAccount | 22,401 | 29,480 | 2,175 | 19,672 |
| NativeFunctionDelegate | 560 | 587 | 24,016 | 48,565 |
| NativeTokenLimitModule | 4,498 | 4,525 | 20,078 | 44,627 |
| PaymasterGuardModule | 1,845 | 1,872 | 22,731 | 47,280 |
-| SemiModularAccount7702 | 23,315 | 30,107 | 1,261 | 19,045 |
-| SemiModularAccountBytecode | 23,797 | 30,596 | 779 | 18,556 |
-| SemiModularAccountStorageOnly | 24,279 | 31,078 | 297 | 18,074 |
+| SemiModularAccount7702 | 23,315 | 30,387 | 1,261 | 18,765 |
+| SemiModularAccountBytecode | 23,797 | 30,876 | 779 | 18,276 |
+| SemiModularAccountStorageOnly | 24,279 | 31,358 | 297 | 17,794 |
| SingleSignerValidationModule | 3,646 | 3,673 | 20,930 | 45,479 |
| TimeRangeModule | 2,085 | 2,112 | 22,491 | 47,040 |
| WebAuthnValidationModule | 7,854 | 7,881 | 16,722 | 41,271 |Code coverage:
|
OverviewOctane AI analysis has finished. No vulnerabilities were found. Cheers! 🎉🎉🎉 🔗 Commit Hash: 4e13dd0 |
jaypaik
deleted the
11-22-fix_s6_alchemy-010_uninstall_revert_on_inconsistent_config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds additional data for other errors for consistency.