test: [QS ALC-9] add more tests for insufficient return data and clarifying comments #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary by OctaneNew ContractsNo new contracts were added in this PR. Updated Contracts
🔗 Commit Hash: efa10fd |
|
Contract sizes: | Contract | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
|-------------------------------|------------------|-------------------|--------------------|---------------------|
| AccountFactory | 4,814 | 5,239 | 19,762 | 43,913 |
| AllowlistModule | 9,903 | 9,930 | 14,673 | 39,222 |
| ExecutionInstallDelegate | 5,714 | 5,760 | 18,862 | 43,392 |
| ModularAccount | 21,973 | 28,676 | 2,603 | 20,476 |
| NativeFunctionDelegate | 434 | 461 | 24,142 | 48,691 |
| NativeTokenLimitModule | 4,449 | 4,476 | 20,127 | 44,676 |
| PaymasterGuardModule | 1,845 | 1,872 | 22,731 | 47,280 |
| SemiModularAccountBytecode | 23,275 | 29,978 | 1,301 | 19,174 |
| SemiModularAccountStorageOnly | 23,769 | 30,472 | 807 | 18,680 |
| SingleSignerValidationModule | 3,646 | 3,673 | 20,930 | 45,479 |
| TimeRangeModule | 2,000 | 2,027 | 22,576 | 47,125 |
| WebAuthnValidationModule | 7,854 | 7,881 | 16,722 | 41,271 |Code coverage:
|
OverviewOctane AI analysis has finished. No vulnerabilities were found. Cheers! 🎉🎉🎉 🔗 Commit Hash: efa10fd |
Zer0dot
reviewed
Nov 12, 2024
Zer0dot
approved these changes
Nov 12, 2024
adamegyed
force-pushed
the
adam/fix-qs-9
branch
from
97354c5 to
efa10fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Addresses QS ALC-9.
This is not an issue, because yul expressions evaluate right-to-left: https://docs.soliditylang.org/en/v0.8.27/yul.html#function-calls
Solution
Add additional tests that verify this behavior. There was one unit test that already checked this behavior in
test_uoCallBuffer_shortReturnData, which only tested for short return data coming from a pre-validation hook, so this PR adds tests for user op validation and for signature validation.Also adds clarifying comments in ExecutionLib.