-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include Gromacs extended ensemble data set #4
Comments
@davidlmobley can you please add @trje3733 to the alchemistry org so that we can assign this issue to him? Thanks! |
Done. But, I also have you set as an administrator for |
Thanks!
… On Nov 14, 2017, at 1:32 PM, David L. Mobley ***@***.***> wrote:
Done. But, I also have you set as an administrator for alchemlyb and alchemtest so you should be able to add people to those directly via their settings without involving me.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAOhnDNYL33No1G45LZaCb_kmpK1StK7ks5s2fjygaJpZM4P_47F>.
--
Oliver Beckstein
[email protected] * [email protected]
|
We are developing 4-5 tests that handle different possible cases. Should each of these tests each be it's own directory, or be subdirectories of a single one? With only one example so far, it's hard to see what the directory structure should be. |
The directory structure is flexible. The main thing is to make sure that you define good accessor functions. Because it is Gromacs it should go under
In Or do you think it will work better in some other way? |
Btw, the amber test files now follow a similar pattern, see https://github.com/alchemistry/alchemtest/tree/master/src/alchemtest/amber |
Have I been added to alchemtest yet? If not, could I be added soon? |
@trje3733 I thought you had been added to the org but I didn't see you there so I sent you invites as "collaborator" for alchemlyb and alchemtest. Let me know if they got stuck somewhere. |
@trje3733 , for the development process see https://github.com/alchemistry/alchemlyb/wiki/Developer-Guide and create a PR. Thanks! |
- include extended ensemble test cases from #4 in gmx.rst - added sub-headings to distinguish Simple TI/FEP and Extended ensemble test data (note: do not use ==== underline because that is used in descr.rst, use --- over+underline)
* display extended ensemble data in docs - include extended ensemble test cases from #4 in gmx.rst - added sub-headings to distinguish Simple TI/FEP and Extended ensemble test data (note: do not use ==== underline because that is used in descr.rst, use --- over+underline) * small reST fixes in extended ensemble descriptions * Fixes so that the docs build without issues. For instance, make the citation markers unique.
To test extended ensembles produced with Gromacs we need to include a data set. alchemistry/alchemlyb#14 includes a zip file (provided by @mrshirts ) that need to be analyzed, evaluated if it fits into alchemtest, and eventually included.
The text was updated successfully, but these errors were encountered: