Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Grouped Settings being split between Group Buttons #17

Open
LightTab2 opened this issue Oct 18, 2024 · 0 comments · May be fixed by #18
Open

[BUG] Grouped Settings being split between Group Buttons #17

LightTab2 opened this issue Oct 18, 2024 · 0 comments · May be fixed by #18

Comments

@LightTab2
Copy link
Contributor

LightTab2 commented Oct 18, 2024

Description:
Adding Settings that belong to different Groups in unorderly manner like this:

add_setting(IntSetting.new("setting_2", "group 2", "my special int setting", 1, 0, 10, "pcs"))
add_setting(StringSetting.new("My string setting", "String group", "some tooltip"))
add_setting(ColorSetting.new("Color", "group 2", ""))

Causes them to display in a very unintuitive way.

Expected behavior:
The Groups should aggregate Settings, even if they are added after another Group's Settings.

Screenshots:
image
Notice that only Group 2 is open, so only Settings from that Group are seen.

Additional info:

  • OS: Windows 11
  • Godot Version: 4.3
  • Commit: a876936
LightTab2 added a commit to LightTab2/SEAL that referenced this issue Oct 18, 2024
Simply separates *Group Buttons* adding from *Settings* adding.
First a *Group* is added and then whole *Settings Dictionary* is searched for *Settings* from that *Group*
@LightTab2 LightTab2 linked a pull request Oct 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant