Suffix reserved names with underscore. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alavrik
added a commit
that referenced
this pull request
May 17, 2014
Suffix reserved names with underscore.
|
Absolutely. I think this is a well-balanced solution to a rather common problem. Thank you! |
This was referenced May 17, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running piqi-ocaml on a bunch of external proto files and found it was a bit of a hazzle to deal with reserved names, most notoriously "type". Can you accept this patch which adds an understore to all the standard keywords? It also adds an option --reserved-name to add additional keywords, e.g. when using a syntax extension.