Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds packages to the dune install invocaton #20

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

ivg
Copy link
Contributor

@ivg ivg commented Aug 3, 2022

Not sure why we can't reproduce it locally, I even installed exactly the same tools versions. But it looks like that this is related to ocaml/dune#5969 and ocaml/dune#4814

I will update accordingly the opam-repository's opam file. In my fork the tests are passing and I hope that they will still pass when we will push it.

@alavrik alavrik merged commit 6f7b299 into alavrik:master Aug 3, 2022
@alavrik
Copy link
Owner

alavrik commented Aug 3, 2022

thanks @ivg! Note that I made one small package name change to make it less confusing going forward: db66cb3

@ivg
Copy link
Contributor Author

ivg commented Aug 3, 2022

Well, for that you have to change the name itself,

- File "dune-project", line 2, characters 6-10:
- 2 | (name piqi)
-           ^^^^
- Error: Package piqi doesn't exist.

Not sure if this change reduces confusion on increases it ;) Now we have the piqi opam package that doesn't even define a piqi package.

@alavrik
Copy link
Owner

alavrik commented Aug 3, 2022

yeah... ok changed it back for now: 8081d0a

looks like the name "package" is overloaded and opam and dune have different views on it. I wish there was a single tool that does everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants