Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uses explicit install field to install packages #18

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

ivg
Copy link
Contributor

@ivg ivg commented Aug 2, 2022

With dune -p piqi,piqirun @install dune generates two proper install packages piqi.install and piqirun.install. However, opam will only use the piqi.install file and ignore the latter, so the piqirun library is not installed.

ivg added 2 commits August 2, 2022 16:12
With  `dune -p piqi,piqirun @install` dune generates two proper
install packages `piqi.install` and `piqirun.install`. However, opam
will only use the `piqi.install` file and ignore the latter, so the
`piqirun` library is not installed.
@alavrik alavrik merged commit 44d986b into alavrik:master Aug 3, 2022
@alavrik
Copy link
Owner

alavrik commented Aug 3, 2022

@ivg something is failing with opam install in CI: https://github.com/alavrik/piqi-ocaml/runs/7652502891?check_suite_focus=true#step:4:4771

looks like it maybe related to sandboxing? I don't see it when running locally on mac. Any idea why these .install files may not be there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants