Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switches to dune #17

Merged
merged 4 commits into from
Aug 2, 2022
Merged

switches to dune #17

merged 4 commits into from
Aug 2, 2022

Conversation

ivg
Copy link
Contributor

@ivg ivg commented Jul 29, 2022

The only breaking change is that we have piqirun.pb and piqirun.ext but not piqirun, dune doesn't allow this. It should be noted that, in fact, piqirun was an empty library, which shouldn't be referenced at all and probably was added accidentally. See alavrik/piqi#68

ivg added 2 commits July 29, 2022 18:29
The only breaking change is that we have piqirun.pb and piqirun.ext
but not piqirun, dune doesn't allow this. It should be noted that, in
fact, piqirun was an empty library, which shouldn't be referenced at
all and probably was added accidentally.
@alavrik
Copy link
Owner

alavrik commented Aug 1, 2022

Thanks @ivg. dune build is returning an error when trying to build:

% dune build -p piqi
File "dune-project", line 4, characters 0-24:
4 | (package (name piqirun))
    ^^^^^^^^^^^^^^^^^^^^^^^^
Error: when a single package is defined, it must have the same name as the
project name: piqi

I've just tried the latest dune 3.4.1

@alavrik
Copy link
Owner

alavrik commented Aug 1, 2022

@ivg this seems to fix it. What do you think? 1b68832

this essentially results in a new empty piqi package, but hope it doesn't cause any confusion

@ivg
Copy link
Contributor Author

ivg commented Aug 1, 2022

It sounds good. See my other comment in the related PR. It might be that the opam-repository maintainers will ask us to split the packages so that we have a one-to-one correspondence. But so far it looks like it works as it is.

@alavrik alavrik merged commit afa0df5 into alavrik:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants