Load plugins in the frontend and honour pragmas and cabal #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just time, will be done soon. |
|
@fendor So If I build hie with this pr Polysemy plugin works? |
|
Yes, the example project worked fine. |
|
Would love for this to be in the next HIE release |
|
It will be, my task for tomorrow |
|
Is it feasible to upstream this into hie-bios? haskell/hie-bios#16 EDIT: sorry, thought this was |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #19 which reverts changes of #19.
@mpickering fixed the problem of #19, that plugin pragmas in source files are not being honoured.
Now ghc-mod correctly detects the plugin param in *.cabal and source pragma.
This reverts the previous changes since they are not necessary anymore.
Problem: In the logs of ghc-mod, you still see the type errors, but they are not reported to hie. May lead to confusion for people that have the logs constantly open.