Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invidio.us parsing #21

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rodolpheh
Copy link

Add invidio.us parsing. It is basically the same as YouTube, so a lot of copy-pasted code. A refactoring could allow both YouTube and Invidio.us parsing to reuse the same code...

@rodolpheh
Copy link
Author

Checks are failing for multiple reasons :

  • The Vimeo video used in the tests doesn't exist anymore (fixed in local copy, commit coming soon)
  • One of the invidio.us test doesn't use the good expected URL (wrong ID, fixed in local copy, commit coming soon)
  • Dailymotion changed their URLs and returns either s1.dmcdn.net or s2.dmcdn.net so tests may work if you're lucky (searching how to fix it)

Rodolphe Houdas added 3 commits July 26, 2020 11:13
The thumbnail tests would return s1.dmcdn.net or s2.dmcdn.net randomly. By
using the v5 of tape, we can use regexp to match one of the subdomains.
@rodolpheh
Copy link
Author

Fixed dailymotion tests by updating tape to 5.0.1 and using a regexp to match one of the subdomains.

@rodolpheh
Copy link
Author

rodolpheh commented Aug 6, 2020

Since the main invidious instance will stop on September first, I'm not sure this pull request is really useful...
(source : https://omar.yt/posts/stepping-away-from-open-source)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant