Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community #296

Merged
merged 4 commits into from
Feb 7, 2025
Merged

Community #296

merged 4 commits into from
Feb 7, 2025

Conversation

mastoffel
Copy link
Collaborator

@mastoffel mastoffel commented Feb 5, 2025

  • fix links
  • create gh-action to publish to pypi
  • add release docs for maintainers

change links in CONTRIBUTING to point to docs
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.17%. Comparing base (7a4dc72) to head (f821e6b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
- Coverage   94.20%   94.17%   -0.03%     
==========================================
  Files          62       62              
  Lines        3606     3606              
==========================================
- Hits         3397     3396       -1     
- Misses        209      210       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  autoemulate/emulators
  gaussian_process.py
Project Total  

This report was generated by python-coverage-comment-action

test release workflow

fix workflow

fix workflow

fix workflow

fix test release workflow

fix test release workflow

fix test release workflow

add release workflow
@mastoffel
Copy link
Collaborator Author

@marjanfamili @radka-j . I've added a gh-action workflow to automatically release the package on PyPi when pushing a new version tag as suggested in #287. To make this clear, I added a guide in the documentation (docs/community/release.md). I'm just wondering now whether this should just be under "community" as releasing requires maintainer rights, or whether we should have a seperate maintainer section or so for this. Would do you think?

Copy link
Collaborator

@marjanfamili marjanfamili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@radka-j radka-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The updated links work for me.

Only thought I had was whether there are any versioning guidelines we follow that we can link to in the release section? There might not be, this stuff is probably always more subjective than anything else.

I think keeping the release docs in the community section as is or adding a new maintainer section are both equally good options so pick whichever you're most comfortable with.

@mastoffel
Copy link
Collaborator Author

Thanks both! @radka-j I added this guide, which I think is simple and intuitive.

@mastoffel mastoffel merged commit 005b3c0 into main Feb 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants