Skip to content

Commit

Permalink
Clarify rationale for returning OK
Browse files Browse the repository at this point in the history
  • Loading branch information
alamb committed Oct 22, 2024
1 parent ff9dc06 commit fd15523
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion datafusion/sqllogictest/bin/sqllogictests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,13 @@ async fn run_tests() -> Result<()> {
env_logger::init();

let options: Options = clap::Parser::parse();
// nextest parses stdout
if options.list {
// nextest parses stdout, so print messages to stderr
eprintln!("NOTICE: --list option unsupported, quitting");
// return Ok, not error so that tools like nextest which are listing all
// workspace tests (by running `cargo test ... --list --format terse`)
// do not fail when they encounter this binary. Instead, print nothing
// to stdout and return OK so they can continue listing other tests.
return Ok(());
}
options.warn_on_ignored();
Expand Down

0 comments on commit fd15523

Please sign in to comment.