Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Piotr Findeisen <[email protected]>
  • Loading branch information
alamb and findepi authored Dec 18, 2024
1 parent c6790f5 commit f8b78a9
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions datafusion/expr-common/src/signature.rs
Original file line number Diff line number Diff line change
Expand Up @@ -114,15 +114,15 @@ pub enum TypeSignature {
Uniform(usize, Vec<DataType>),
/// One or more arguments with exactly the specified types in order.
///
/// For functions that take no arguments (e.g. `random()` see [`TypeSignature::Nullary`]).
/// For functions that take no arguments (e.g. `random()`) use [`TypeSignature::Nullary`].
Exact(Vec<DataType>),
/// One or more arguments belonging to the [`TypeSignatureClass`], in order.
///
/// For example, `Coercible(vec![logical_float64()])` accepts
/// arguments like `vec![DataType::Int32]` or `vec![DataType::Float32]`
/// since i32 and f32 can be cast to f64
///
/// For functions that take no arguments (e.g. `random()` see [`TypeSignature::Nullary`]).
/// For functions that take no arguments (e.g. `random()`) see [`TypeSignature::Nullary`].
Coercible(Vec<TypeSignatureClass>),
/// One or more arguments that can be "compared"
///
Expand All @@ -140,7 +140,7 @@ pub enum TypeSignature {
Comparable(usize),
/// One or more arguments of arbitrary types.
///
/// For functions that take no arguments (e.g. `random()` see [`TypeSignature::Nullary`]).
/// For functions that take no arguments (e.g. `random()`) use [`TypeSignature::Nullary`].
Any(usize),
/// Matches exactly one of a list of [`TypeSignature`]s.
///
Expand All @@ -158,7 +158,7 @@ pub enum TypeSignature {
///
/// See [`NativeType::is_numeric`] to know which type is considered numeric
///
/// For functions that take no arguments (e.g. `random()` see [`TypeSignature::Nullary`]).
/// For functions that take no arguments (e.g. `random()`) use [`TypeSignature::Nullary`].
///
/// [`NativeType::is_numeric`]: datafusion_common::types::NativeType::is_numeric
Numeric(usize),
Expand Down

0 comments on commit f8b78a9

Please sign in to comment.