Skip to content

Commit

Permalink
Improve MSRV CI check to print out problems to log
Browse files Browse the repository at this point in the history
  • Loading branch information
alamb committed Aug 2, 2024
1 parent eca762a commit 7350db6
Showing 1 changed file with 17 additions and 9 deletions.
26 changes: 17 additions & 9 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -566,18 +566,26 @@ jobs:
- name: Check datafusion
working-directory: datafusion/core
run: |
# If you encounter an error with any of the commands below
# it means some crate in your dependency tree has a higher
# MSRV (Min Supported Rust Version) than the one specified
# in the `rust-version` key of `Cargo.toml`. Check your
# dependencies or update the version in `Cargo.toml`
cargo msrv verify
# If you encounter an error with any of the commands below it means
# your code or some crate in the dependency tree has a higher MSRV
# (Min Supported Rust Version) than the one specified in the
# `rust-version` key of `Cargo.toml`.
#
# To resolve, either:
# 1. Change your code to use older Rust features,
# 2. Revert dependency update
# 3. Update the MSRV version in `Cargo.toml`
#
# Please see the DataFusion Rust Version Compatibility Policy before
# updating Cargo.toml. You may have to update the code instead.
# https://github.com/apache/datafusion/blob/main/README.md#rust-version-compatibility-policy
cargo msrv verify --log-target stdout
- name: Check datafusion-substrait
working-directory: datafusion/substrait
run: cargo msrv verify
run: cargo msrv verify --log-target stdout
- name: Check datafusion-proto
working-directory: datafusion/proto
run: cargo msrv verify
run: cargo msrv verify --log-target stdout
- name: Check datafusion-cli
working-directory: datafusion-cli
run: cargo msrv verify
run: cargo msrv verify --log-target stdout

0 comments on commit 7350db6

Please sign in to comment.