String dictionary test

alamb · Dec 14, 2024 · 3151275 · 3151275
1 parent 311f050
commit 3151275
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/datafusion/common/src/scalar/mod.rs b/datafusion/common/src/scalar/mod.rs
@@ -5577,16 +5577,14 @@ mod tests {
             Arc::new(StringArray::from(vec![Some("foo"), None, Some("bar")])),
             Arc::new(LargeStringArray::from(vec![Some("foo"), None, Some("bar")])),
             Arc::new(StringViewArray::from(vec![Some("foo"), None, Some("bar")])),
-            // string dictionary fails due to XXX
-            /*
+            // string dictionary
             {
                 let mut builder = StringDictionaryBuilder::<Int32Type>::new();
                 builder.append("foo").unwrap();
                 builder.append_null();
                 builder.append("bar").unwrap();
                 Arc::new(builder.finish())
             },
-            */
             // binary array
             Arc::new(BinaryArray::from_iter(vec![
                 Some(b"foo"),