-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps to fix some vulnerability issues #154
Conversation
npm reported some issues in the dependencies. These are the automatic fixes.
open is unmaintained and has a critical vulnerability issue: pwnall/node-open#67. opn is pretty much a drop in replacement.
FYI after this there are still some issues that can be fixed by updating two packages, they're potentially breaking changes though & I'm not that familiar with this to know whether that's ok
|
Thanks for the MRs will look at these this week |
Thanks @Jezzamonn, sorry this took so long. I will clean up the other security problems right after this |
It's awesome to see you were responsive to this issue! |
Thanks I appreciate that! I personally should have triaged it and taken care of it a lot faster |
No problem, I've had maintainers ask me for donations to merge security patches ... This is refreshing 🍹 |
Running
npm audit
shows some vulnerabilities. This fixes those that can be fixed automatically and also replaces the open package with opn to remove dependency on the critical security issue.