Improvement for EspionageReportSummary #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 26, 2020 16:59
Extra EspionageReportSummary parsing Extra EspionageReportSummary parsing alaingilbert#2
|
Instead of dealing with function "parseRes" we could also return the original text and let the client deal with parsing (in regards to language / locale issues)? |
|
na, the wrapper should return the values |
added 2 commits
March 30, 2020 23:43
…feature/espionage_improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parses all fields from EspionageReportSummary.
Code is in the v7.1 extract files, but the HTML is in the v7.2 directory in samples. If you want me to move this to a 7.2 file for extracts let know. Maybe we can even discard the changes in v6 file or remove all those old ones.