Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: fix no-unused-vars (fixes #44) #45

Merged
merged 4 commits into from
Jun 9, 2019
Merged

Fix: fix no-unused-vars (fixes #44) #45

merged 4 commits into from
Jun 9, 2019

Conversation

g-plane
Copy link
Collaborator

@g-plane g-plane commented Jun 9, 2019

No description provided.

@g-plane g-plane requested a review from aladdin-add June 9, 2019 02:07
aladdin-add
aladdin-add approved these changes Jun 9, 2019
View reviewed changes
Copy link
Owner

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

it would be fine to add some cases to cover array destructurting:

var [a, b] = [];

tests/lib/rules/no-unused-vars.js Outdated Show resolved Hide resolved
@g-plane g-plane requested a review from aladdin-add June 9, 2019 03:24
@g-plane g-plane merged commit eb118f1 into master Jun 9, 2019
@g-plane g-plane deleted the fix-44 branch June 9, 2019 03:33
@g-plane g-plane mentioned this pull request Jun 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aladdin-add aladdin-add aladdin-add approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g-plane @aladdin-add