Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying of all fields of Self is replaced with modification of only modifying field of interest #52

Merged
merged 2 commits into from
May 4, 2023

Conversation

peter-scholtens
Copy link
Contributor

Copying a struct with 14 usize fields will require 47 assembly instruction while modifying Self only takes 9. Also the code readability is improved.

… of interest.

Copying a struct with 14 usize fields will require 47 assembly instruction while modifying Self only takes 9. Also the code readability is improved.
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage: 86.36% and project coverage change: +0.73 🎉

Comparison is base (e89d308) 83.91% compared to head (7e03b66) 84.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   83.91%   84.65%   +0.73%     
==========================================
  Files          17       17              
  Lines        1921     1844      -77     
==========================================
- Hits         1612     1561      -51     
+ Misses        309      283      -26     
Impacted Files Coverage Δ
src/cache/builder.rs 86.36% <85.71%> (+8.28%) ⬆️
src/bbloom.rs 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@al8n al8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@al8n al8n merged commit 18a12c9 into al8n:main May 4, 2023
@peter-scholtens peter-scholtens deleted the compact-settings branch May 4, 2023 06:19
al8n pushed a commit that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants