FileExt methods cause compiler warnings on rust 1.84

[eric-seppanen]

Using the lock methods from fs_std cause rustc warnings on rust 1.84:

use fs4::fs_std::FileExt;

pub fn read_file(filename: &str) -> String {
    let mut file = std::fs::File::open(filename).unwrap();
    file.lock_shared().unwrap();
    let mut data = String::new();
    file.read_to_string(&mut data).unwrap();
    data
}

$ cargo +beta-2024-11-27 check

warning: a method with this name may be added to the standard library in the future
  --> src/lib.rs:10:10
   |
10 |     file.lock_shared().unwrap();
   |          ^^^^^^^^^^^
   |
   = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior!
   = note: for more information, see issue #48919 <https://github.com/rust-lang/rust/issues/48919>
   = help: call with fully qualified syntax `lock_shared(...)` to keep using the current method
   = note: `#[warn(unstable_name_collisions)]` on by default

The name collision happens for lock_shared, try_lock_shared, and unlock, which are tracked by the file_lock feature (rust-lang/rust#130994).

[al8n]

Hi, is the warning still there in the latest version? I test it on the my local machine, it seems that no warnings anymore.

[ofek]

I still see the warnings on the latest version and is making CI fail.

[al8n]

I still see the warnings on the latest version and is making CI fail.

Which OS are you using? In fs4's CI, there are no warnings. Maybe using FileExt::lock_* instead of using file.lock_* can solve the problem?

[ofek]

Yes that is what I did to fix the issue https://github.com/ofek/pyapp/pull/181/files#diff-4a528b12e365aa6a3f59b039dfbaa1e9b343724b2d56f6337fc492826afd4a7c