Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option "target2current_temp" for aircondition devices #1185

Merged
merged 3 commits into from
Nov 6, 2023
Merged

add option "target2current_temp" for aircondition devices #1185

merged 3 commits into from
Nov 6, 2023

Conversation

Jack-Works
Copy link
Contributor

@Jack-Works Jack-Works commented Jun 28, 2023

this new option "target2current_temp" enables the following behavior:

  • if the air conditioner is on, report target_temperature as current_temperature.
  • if it is off, fallback to either bind_sensor or current_temp_prop.

this PR supports the following use case:

  • expect HomeKit displays the target temperature instead and
  • there is no sensor available in the room where the air conditioner works (therefore bind_sensor binds to a sensor in another room or the weather report sensor). If you have a sensor in the room, you don't need this option, just use bind_sensor.

with this option enabled, HomeKit reports the target temperature when it's on, and reports the sensor's temperature/temperature from the weather report when the air condition is off.

@al-one
Copy link
Owner

al-one commented Oct 12, 2023

@Jack-Works Good idea! It's just that the option name report_target_temp_as_current_temp is too long. Can it be simplified?

@Jack-Works
Copy link
Contributor Author

@Jack-Works Good idea! It's just that the option name report_target_temp_as_current_temp is too long. Can it be simplified?

I think that name reflects what it does. Can you think of any shorter name that still explain the functionality?

@al-one
Copy link
Owner

al-one commented Oct 13, 2023

We have a similar option called target2current_position to cover entities, maybe this option could be named target2current_temp.

@Jack-Works Jack-Works changed the title add option "report_target_temp_as_current_temp" for aircondition devices add option "target2current_temp" for aircondition devices Oct 13, 2023
@al-one al-one merged commit 61b69eb into al-one:master Nov 6, 2023
@Jack-Works Jack-Works deleted the climate-temp branch November 7, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants