Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1050 modify cascade type question to support entities #1075

Merged
merged 40 commits into from
Jan 30, 2024
Merged

Feature/1050 modify cascade type question to support entities #1075

merged 40 commits into from
Jan 30, 2024

Conversation

ifirmawan
Copy link
Contributor

@ifirmawan ifirmawan commented Jan 24, 2024 •
edited
Loading

TODO/DONE

BACKEND

  • Update form details API to add parentCascade
  • Example entities seeder related to the form JSON

MOBILE

  • Implements cascade entities
  • Update TypeCascade test

@ifirmawan ifirmawan self-assigned this Jan 24, 2024
@coveralls
Copy link

coveralls commented Jan 24, 2024 •
edited
Loading

Coverage Status

coverage: 80.861% (-0.2%) from 81.013%
when pulling 69483a6 on feature/1050-modify-cascade-type-question-to-support-entities
into d79025b on develop.

@ifirmawan
Merge branch 'develop' into feature/1050-modify-cascade-type-question…
163cf4f 
…-to-support-entities
@ifirmawan
Merge branch 'develop' into feature/1050-modify-cascade-type-question…
e2e2b3a 
…-to-support-entities
@ifirmawan
[#1050] Fix all failed test cases in TypeCascade
b95c2b8
@ifirmawan
[#1050] Fix invalid grouping datasource
adf5205
@ifirmawan
[#1050] Include entity type directly in form details response
04d88b3
@ifirmawan
[#1050] Add more entity cascade and define entity type by extra.name
2973663
@ifirmawan
Merge branch 'develop' into feature/1050-modify-cascade-type-question…
ed7f429 
…-to-support-entities
@ifirmawan
[#1050] Replace pd with np to handle unique source sqlite
68245db 
Provide a unique SQLite file for the mobile app to prevent downloading the same file or duplication.
@ifirmawan
[#1050] Finalizing entity cascade test cases
9c54cfc
@ifirmawan
[#1050] Remove unused dropdownTypes since the entity type has already…
4450279 
… been defined in the question.
@ifirmawan ifirmawan marked this pull request as ready for review January 25, 2024 13:46
dedenbangkit
dedenbangkit requested changes Jan 26, 2024
View reviewed changes
Copy link
Member

@dedenbangkit dedenbangkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ifirmawan, this isn't work without Entity seeder. Could you please create seeder for the example entities you have in HH Form?

@ifirmawan
Copy link
Contributor Author

Hi @ifirmawan, this isn't work without Entity seeder. Could you please create seeder for the example entities you have in HH Form?

Sure mas @dedenbangkit , on it

dedenbangkit
dedenbangkit requested changes Jan 29, 2024
View reviewed changes
Copy link
Member

@dedenbangkit dedenbangkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide question if previous administration answer is null

@ifirmawan ifirmawan marked this pull request as draft January 29, 2024 13:41
@ifirmawan ifirmawan marked this pull request as ready for review January 29, 2024 14:21
@ifirmawan
Copy link
Contributor Author

Hide question if previous administration answer is null

Hi mas @dedenbangkit , I've fixed it and it's ready for review. Thank you

@dedenbangkit
Copy link
Member

Hide question if previous administration answer is null

Hi mas @dedenbangkit , I've fixed it and it's ready for review. Thank you

Hi @ifirmawan, please fix the conflict first

@ifirmawan
Copy link
Contributor Author

Hide question if previous administration answer is null

Hi mas @dedenbangkit , I've fixed it and it's ready for review. Thank you

Hi @ifirmawan, please fix the conflict first

Noted, done mas.

@ifirmawan ifirmawan linked an issue Jan 30, 2024 that may be closed by this pull request
Modify Cascade Type Question to Support Entities #1050
Closed
3 tasks
@dedenbangkit dedenbangkit merged commit 4484fd0 into develop Jan 30, 2024
2 checks passed
@dedenbangkit dedenbangkit deleted the feature/1050-modify-cascade-type-question-to-support-entities branch January 30, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedenbangkit dedenbangkit Awaiting requested review from dedenbangkit

Assignees

@ifirmawan ifirmawan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify Cascade Type Question to Support Entities
3 participants
@ifirmawan @coveralls @dedenbangkit