[#5080] Added active state to fix indicator approval workflow #5084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifirmawan
force-pushed
the
5080-feature-request-nuffic-indicator-approval-workflow
branch
from
a972475 to
4a5946b
Compare
ifirmawan
changed the title
ifirmawan
force-pushed
the
5080-feature-request-nuffic-indicator-approval-workflow
branch
2 times, most recently
from
6e9e9f5 to
11f3ef3
Compare
navins94
reviewed
Aug 29, 2022
| import approvedSvg from '../images/status-approved.svg' | ||
| import pendingSvg from '../images/status-pending.svg' | ||
| import revisionSvg from '../images/status-revision.svg' | ||
| import { DeclinePopup } from './DeclinePopup' | ||
|
|
||
| const Aux = node => node.children | ||
|
|
||
| export const StatusPeriod = ({ update, pinned, index, handleUpdateStatus, t }) => { | ||
| export const StatusPeriod = ({ update, pinned, index, handleUpdateStatus }) => { | ||
| const { t } = useTranslation() |
There was a problem hiding this comment.
It's better to have descriptive name instead of t
There was a problem hiding this comment.
Noted, Thank you Navin. Fixing in progress
| <Col lg={22} md={22} sm={24} xs={24}> | ||
| {isEmpty(period) && ( | ||
| <div className="period-caption"> | ||
| {moment(item?.period?.periodStart, 'DD/MM/YYYY').format('DD MMM YYYY')} - {moment(item?.period?.periodEnd, 'DD/MM/YYYY').format('DD MMM YYYY')} |
There was a problem hiding this comment.
It would be nice to create variable and assign values and render variable. If later on we convert it to component it would be easier to just pass the variable instead
| )} | ||
| > | ||
| <div className="period-caption"> | ||
| {`${moment(period?.periodStart, 'DD/MM/YYYY').format('DD MMM YYYY')} - ${moment(period?.periodEnd, 'DD/MM/YYYY').format('DD MMM YYYY')}`} |
There was a problem hiding this comment.
It would be nice to create variable and assign values and render variable. If later on we convert it to component it would be easier to just pass the variable instead
ifirmawan
force-pushed
the
5080-feature-request-nuffic-indicator-approval-workflow
branch
from
11f3ef3 to
b827e0d
Compare
ifirmawan
force-pushed
the
5080-feature-request-nuffic-indicator-approval-workflow
branch
from
b827e0d to
4ee4908
Compare
[#5051] Make audit trail components responsive in mobile view
Active status helps MnE managers to identify updates of indicators that have an unlocked period still in progress. the following what has to be done in order to finalize this feature : 1. Update status description. 2. Add new icon history. 3. Create audit trail modal 4. Call /indicator_period_data_framework/ by period Pulling data audit trails from endpoint /indicator_period_data_framework/ by period ID of selected update.
ifirmawan
force-pushed
the
5080-feature-request-nuffic-indicator-approval-workflow
branch
from
4ee4908 to
4c408fd
Compare
- Reduce time column size. - Add new constant variable for status terminology.
ifirmawan
force-pushed
the
5080-feature-request-nuffic-indicator-approval-workflow
branch
from
4c408fd to
0519265
Compare
|
Adding link to #5080 for Zenhub |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO / Done
Summarize what has been changed / what has to be done in order to finalize the PR.
Test plan
What tests are necessary to ensure this works or doesn't break anything working
View history at reporting period