Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: angular 7+ update #929

Merged
merged 9 commits into from
Nov 14, 2018
Merged

chore: angular 7+ update #929

merged 9 commits into from
Nov 14, 2018

Conversation

Tibing
Copy link
Member

@Tibing Tibing commented Oct 22, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Bump Angular dependencies to the latest versions.

Closes #928

BREAKING CHANGES:
Angular 7+ now required.

@Tibing Tibing requested a review from nnixaa October 22, 2018 11:22
@Tibing Tibing force-pushed the chore/update-angular branch from 2e88345 to d279652 Compare October 22, 2018 13:07
@Tibing Tibing added the WIP label Oct 23, 2018
Tibing and others added 4 commits October 23, 2018 15:18
Angular CLI no longer support capability specify project in any place between options.
We have to pass it as first argument now.
@Tibing Tibing removed the WIP label Oct 25, 2018
@Prefix1802 Prefix1802 mentioned this pull request Oct 26, 2018
1 task
@Prefix1802
Copy link
Contributor

akveo/ngx-admin#1890

@Tibing Tibing changed the title Chore/update angular chore: angular 7+ update Nov 14, 2018
@Tibing Tibing requested a review from yggg November 14, 2018 12:21
@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

Merging #929 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #929   +/-   ##
=======================================
  Coverage   76.99%   76.99%           
=======================================
  Files         200      200           
  Lines        5950     5950           
  Branches      452      452           
=======================================
  Hits         4581     4581           
  Misses       1263     1263           
  Partials      106      106
Impacted Files Coverage Δ
...rk/theme/components/radio/radio-group.component.ts 77.63% <100%> (ø) ⬆️

@Tibing Tibing merged commit c301718 into akveo:master Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Angular 7
4 participants