Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(theme): remove angular2-toaster styling #721

Merged
merged 1 commit into from
Sep 19, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 1 addition & 22 deletions docs/articles/concept-3rd-party.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,32 +3,11 @@
Currently Nebular Theme system is integrated with the following 3rd party modules:

- ng2-smart-table;
- angular2-toaster.

It means that we've created style overriding for these modules, so that you can change component's look & feel using Nebular theme variables.
For example, if you change the `color-primary` variable, components using this color will be changed accordingly.


Or that's how we described variables for the `angular2-toaster` module:

```scss
...
toaster-bg: color-primary,
toaster-fg-default: color-inverse,
toaster-btn-close-bg: transparent,
toaster-btn-close-fg: toaster-fg-default,
toaster-shadow: shadow,

toaster-fg: color-white,
toaster-success: color-success,
toaster-info: color-info,
toaster-warning: color-warning,
toaster-wait: color-primary,
toaster-error: color-danger,
...

```
<hr>
<hr>

## Related Articles

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* Licensed under the MIT License. See License.txt in the project root for license information.
*/

@mixin nb-toaster-theme() {
@mixin nb-toast-theme() {
nb-toast {
background-color: nb-theme(toastr-bg);
padding: nb-theme(toastr-padding);
Expand Down
2 changes: 1 addition & 1 deletion src/framework/theme/styles/global/_components.scss
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
@include nb-popover-theme();
@include nb-context-menu-theme();
@include nb-select-theme();
@include nb-toaster-theme();
@include nb-toast-theme();
@include nb-tooltip-theme();
@include nb-window-theme();
}
2 changes: 0 additions & 2 deletions src/framework/theme/styles/global/_overrides.scss
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

@import 'normalize.scss';
@import 'components/tree.theme';
@import 'components/toaster.theme';
@import 'maps/leaflet.theme';
@import 'tables/smart-table.theme';

Expand All @@ -17,5 +16,4 @@
@include nb-components-tree-theme();
@include nb-maps-leaflet-theme();
@include nb-tables-smart-table-theme();
@include nb-components-toaster-theme();
}
90 changes: 0 additions & 90 deletions src/framework/theme/styles/global/components/_toaster.theme.scss

This file was deleted.

13 changes: 0 additions & 13 deletions src/framework/theme/styles/themes/_default.scss
Original file line number Diff line number Diff line change
Expand Up @@ -302,19 +302,6 @@ $theme: (
smart-table-paging-bg-active: color-success,
smart-table-paging-hover: rgba(0, 0, 0, 0.05),

toaster-bg: color-primary,
toaster-fg-default: color-inverse,
toaster-btn-close-bg: transparent,
toaster-btn-close-fg: toaster-fg-default,
toaster-shadow: shadow,

toaster-fg: color-white,
toaster-success: color-success,
toaster-info: color-info,
toaster-warning: color-warning,
toaster-wait: color-primary,
toaster-error: color-danger,

toastr-bg: color-bg,
toastr-padding: 1.125rem,
toastr-fg: color-fg-text,
Expand Down