Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(theme): remove angular2-toaster styling #721

Merged
merged 1 commit into from
Sep 19, 2018

Conversation

Tibing
Copy link
Member

@Tibing Tibing commented Sep 18, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

BREAKING CHANGE:
angular2-toaster styles were removed from nebular.
You have to use NbToastrService instead.

  • Add NbToastrModule into imports of your root module.
  • Inject NbToastrService into the required component.
  • call NbToastrService.show(...) to render toasts.

For more information, check toastr documentation.

@Tibing Tibing requested a review from nnixaa September 18, 2018 06:21
@nnixaa
Copy link
Collaborator

nnixaa commented Sep 18, 2018

@Tibing we need to describe the breaking change and how to replace 3rd party toaster with the Nebular one.

@Tibing
Copy link
Member Author

Tibing commented Sep 18, 2018

@nnixaa, done

@nnixaa nnixaa merged commit 026974e into akveo:master Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants