fix(search): fix search not un-subscribing from events (#185)

akveo · Feb 2, 2018 · 691e100 · 691e100
1 parent 2e9d14a
commit 691e100
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 30 deletions.
diff --git a/docs/output.json b/docs/output.json
@@ -2656,13 +2656,6 @@
               "shortDescription": "",
               "description": ""
             },
-            {
-              "name": "componentFactoryResolver",
-              "type": "ComponentFactoryResolver",
-              "required": null,
-              "shortDescription": "",
-              "description": ""
-            },
             {
               "name": "router",
               "type": "Router",
@@ -2700,26 +2693,6 @@
           "shortDescription": "",
           "description": ""
         },
-        {
-          "examples": [],
-          "params": [
-            {
-              "name": "component",
-              "type": "any",
-              "required": null,
-              "shortDescription": "",
-              "description": ""
-            }
-          ],
-          "platform": null,
-          "name": "createAttachedSearch",
-          "type": [
-            "Observable<any>"
-          ],
-          "isStatic": false,
-          "shortDescription": "",
-          "description": ""
-        },
         {
           "examples": [],
           "params": [],
@@ -13859,4 +13832,4 @@
       "parent": "default"
     }
   }
-}
+}
diff --git a/src/framework/theme/components/search/search.component.ts b/src/framework/theme/components/search/search.component.ts
@@ -222,7 +222,7 @@ export class NbSearchComponent implements OnInit, AfterViewInit, OnDestroy {
       )
       .subscribe(event => this.searchService.deactivateSearch(this.searchType, this.tag));
 
-    combineLatest([
+    this.activateSearchSubscription = combineLatest([
       this.searchFieldComponentRef$,
       this.searchService.onSearchActivate(),
     ])
@@ -241,7 +241,7 @@ export class NbSearchComponent implements OnInit, AfterViewInit, OnDestroy {
         componentRef.changeDetectorRef.detectChanges();
       });
 
-    combineLatest([
+    this.deactivateSearchSubscription = combineLatest([
       this.searchFieldComponentRef$,
       this.searchService.onSearchDeactivate(),
     ])