Issue25483 pipeline options refactoring #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
removed
flink
dataflow
go
runners
jdbc
gcp
infra
samza
kafka
extensions
protobuf
labels
alexeyinkin
suggested changes
Apr 12, 2023
playground/frontend/playground_components/lib/src/constants/constants.dart
Outdated
Show resolved
Hide resolved
...d/playground_components/lib/src/widgets/pipeline_options_dropdown/pipeline_option_label.dart
Outdated
Show resolved
Hide resolved
...ayground_components/lib/src/widgets/pipeline_options_dropdown/pipeline_options_dropdown.dart
Show resolved
Hide resolved
...omponents/lib/src/widgets/pipeline_options_dropdown/pipeline_options_dropdown_separator.dart
Outdated
Show resolved
Hide resolved
...nd/playground_components/lib/src/widgets/pipeline_options_dropdown/pipeline_options_row.dart
Outdated
Show resolved
Hide resolved
alexeyinkin
suggested changes
Apr 13, 2023
learning/tour-of-beam/frontend/lib/pages/tour/widgets/pipeline_options.dart
Outdated
Show resolved
Hide resolved
learning/tour-of-beam/frontend/lib/pages/tour/widgets/playground_demo.dart
Show resolved
Hide resolved
playground/frontend/playground_components/lib/src/constants/sizes.dart
Outdated
Show resolved
Hide resolved
alexeyinkin
suggested changes
Apr 18, 2023
playground/frontend/playground_components/lib/src/controllers/playground_controller.dart
Outdated
Show resolved
Hide resolved
alexeyinkin
suggested changes
Apr 18, 2023
| @@ -37,7 +37,7 @@ import 'path.dart'; | |||
|
|
|||
| class TourNotifier extends ChangeNotifier with PageStateMixin<void> { | |||
| final ContentTreeController contentTreeController; | |||
| final PlaygroundController playgroundController; | |||
| PlaygroundController? playgroundController; | |||
There was a problem hiding this comment.
TourNotifier must always have a final PlaygroundController.
When I talked nullable, I meant that TobScaffold.playgroundController should be null.
There was a problem hiding this comment.
TobScaffold does not contains playground controller. Why do you think, that non final PlaygroundController in TourNotifier is a bad idea? I believe that it supports consistenсy of tour notifier, when it does not contains an example
alexeyinkin
suggested changes
Apr 21, 2023
playground/frontend/playground_components/lib/src/controllers/playground_controller.dart
Outdated
Show resolved
Hide resolved
...ound/frontend/playground_components/lib/src/controllers/example_loaders/examples_loader.dart
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: apache#25483
pipeline options extracted to playground_components and added to tour of beam
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.