Refactor output tabs, test running and dark mode in Embedded playground #417
Conversation
| } | ||
|
|
||
| Future<void> _openJavaMinimalWordCount(WidgetTester wt) async { | ||
| await wt.navigateAndSettle(_url); |
There was a problem hiding this comment.
This is not a test but a helper method like we had in standalone_change_example_sdk_run_test.dart
It is extracted so that its name gives a hint of the example name.
| _result = const RunCodeResult( | ||
| status: RunCodeStatus.compileError, | ||
| errorMessage: kPipelineOptionsParseError, | ||
| _setResult( |
There was a problem hiding this comment.
It does not have a corresponding private getter.
| * limitations under the License. | ||
| */ | ||
|
|
||
| import 'package:flutter/widgets.dart'; |
There was a problem hiding this comment.
import 'package:flutter/foundation.dart';
| } | ||
|
|
||
| /// Marks [key] as read. | ||
| void clearKey(K key) { |
| } | ||
|
|
||
| /// Marks all keys as read. | ||
| void clear() { |
| final _unreadKeys = <K>{}; | ||
|
|
||
| /// Marks [key] as unread if [value] differs from the last call. | ||
| void setValue(K key, dynamic value) { |
There was a problem hiding this comment.
No, because we check if the value is new, and it's not a caller's job to know if a call results in anything, this controller is like a simple ValueNotifier it them. We can even rename this to MapValueNotifier or something like this later.
| } | ||
|
|
||
| void _updateGraphPainterIfNeed() { | ||
| final graph = widget.playgroundController.codeRunner.result?.graph ?? ''; |
There was a problem hiding this comment.
This long chain is only used once.
|
|
||
| @override | ||
| Widget build(BuildContext context) { | ||
| final graphPainter = _graphPainter; |
|
|
||
| @override | ||
| Widget build(BuildContext context) { | ||
| final ext = Theme.of(context).extension<BeamThemeExtension>()!; |
There was a problem hiding this comment.
theme is for ThemeData objects, theme extensions are different.
We have ext for this in 7 other locations, this got kind of standard.
| }); | ||
|
|
||
| final bool padding; |
|
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.