Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expo example #3287

Merged
merged 3 commits into from
Sep 21, 2018
Merged

Expo example #3287

merged 3 commits into from
Sep 21, 2018

Conversation

daviscabral
Copy link
Collaborator

Basic Expo example using RNRF.

@daviscabral daviscabral requested a review from aksonov September 21, 2018 14:10
aksonov
aksonov approved these changes Sep 21, 2018
View reviewed changes
Copy link
Owner

@aksonov aksonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aksonov
Copy link
Owner

aksonov commented Sep 21, 2018

Tests are not passed

@daviscabral
Copy link
Collaborator Author

Fixed now.

@daviscabral daviscabral merged commit 47d54c7 into master Sep 21, 2018
@daviscabral daviscabral deleted the expo-example branch September 21, 2018 14:15
daviscabral added a commit that referenced this pull request Sep 21, 2018
@daviscabral
Merge branch 'master' into issue/3258
4e3d11b 
* master:
  Expo example (#3287)
  Update README.md (#3275)

# Conflicts:
#	examples/expo/components/DrawerContent.js
#	examples/expo/navigation/AppNavigator.js
#	examples/expo/package.json
#	examples/expo/screens/HomeScreen.js
#	examples/expo/yarn.lock
This was referenced Sep 21, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aksonov aksonov aksonov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daviscabral @aksonov