Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #3163: Bring TabBarTop and TabBarBottom back to LegacyTabs #3265

Merged
merged 2 commits into from
Sep 13, 2018
Merged

Closes #3163: Bring TabBarTop and TabBarBottom back to LegacyTabs #3265

merged 2 commits into from
Sep 13, 2018

Conversation

daviscabral
Copy link
Collaborator

No description provided.

@daviscabral daviscabral requested a review from aksonov September 13, 2018 14:59
@daviscabral daviscabral mentioned this pull request Sep 13, 2018
Closed
aksonov
aksonov approved these changes Sep 13, 2018
View reviewed changes
Copy link
Owner

@aksonov aksonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aksonov
Copy link
Owner

aksonov commented Sep 13, 2018

So, should we release new version now?

@aksonov aksonov merged commit 71f0fae into master Sep 13, 2018
@daviscabral
Copy link
Collaborator Author

Give me a few minutes - I need to get one more fix pushed - related to one bug I brought to master with the reset/refresh change I did a few days ago.

@aksonov
Copy link
Owner

aksonov commented Sep 14, 2018

Okey, I've just got error tabBarComponent is read-only when set legacy for TabBar (I added legacy to Example). I fixed that but got another error within backToInitial processing, so I disabled backToInitial for legacy at this moment, feel free to fix. Now it works but with warning about jumpToIndex is deprecated - looks like using of old navigators was bad idea...

@daviscabral daviscabral deleted the issue/3163 branch September 14, 2018 18:44
@daviscabral
Copy link
Collaborator Author

Yeah - sorry about that - I noticed it right after, and I thought I was going to be able to fix in time, but I had to stop to work.

I have other PR with that and other stuff in development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aksonov aksonov aksonov approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daviscabral @aksonov