Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3204 onEnter/onExit for Drawer #3254

Merged
merged 2 commits into from
Sep 12, 2018
Merged

Conversation

daviscabral
Copy link
Collaborator

@daviscabral daviscabral commented Sep 11, 2018

This adds support to execute the drawer enter/exit handlers.
That might be also considered a bug - since it accepts onEnter and onExit but does not call it.

Closes #3204.

@daviscabral daviscabral requested a review from aksonov September 11, 2018 09:16
@daviscabral
Copy link
Collaborator Author

@aksonov do you think after this PR we can generate a new release?

@aksonov
Copy link
Owner

aksonov commented Sep 12, 2018

@daviscabral Yes, I think so. Will check it today.

@aksonov
Copy link
Owner

aksonov commented Sep 12, 2018

LGTM

@aksonov aksonov merged commit 2c84fd9 into master Sep 12, 2018
@daviscabral
Copy link
Collaborator Author

Thank you.

@lironhl
Copy link

lironhl commented Oct 8, 2018

onEnter not working inside the contentComponent of the Drawer, for example:
This works fine:
<Drawer contentComponent={SideMenu} onEnter={() => console.log("Drawer Opened")} >

but when I try to declare onEnter inside SideMenu component it won't be executed.
export default class SideMenu extends Component { onEnter() { console.log('Drawer Opened'); } }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants