Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for deprecated Tabs component #3214

Merged
merged 4 commits into from
Sep 3, 2018
Merged

Add support for deprecated Tabs component #3214

merged 4 commits into from
Sep 3, 2018

Conversation

daviscabral
Copy link
Collaborator

Add support to deprecated Tabs component to allow swipeEnabled and animationEnabled. Also updates the API docs to inform that those options are not available to Tabs anymore.

@daviscabral daviscabral requested a review from aksonov August 25, 2018 17:36
aksonov
aksonov approved these changes Sep 3, 2018
View reviewed changes
Copy link
Owner

@aksonov aksonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aksonov
Copy link
Owner

aksonov commented Sep 3, 2018

@daviscabral Do you know why tests fail now (on master)?

@daviscabral
Copy link
Collaborator Author

I believe it's related with the versions - I spent some time tracking the dependency that could be causing it - but without success yet.

@daviscabral
Merge branch 'master' into dc/legacy-tabs
7e63bf5 
* master:
  Add more information to issue template to help figure out cause of problems (#3239)
@daviscabral
Copy link
Collaborator Author

That's weird - locally it's passing. Checking what is going on.

@daviscabral
Copy link
Collaborator Author

@aksonov tests fixed - just lint updates.

@aksonov aksonov merged commit 3ca9a78 into master Sep 3, 2018
@daviscabral daviscabral deleted the dc/legacy-tabs branch September 3, 2018 10:45
daviscabral added a commit that referenced this pull request Sep 6, 2018
@daviscabral
Merge branch 'master' into dc/issues/3236-3218-3206-3197-3188-refresh…
e57e509 
…-not-working-as-expected

* master:
  fixes Actions.reset when getParent returns null (#3245)
  reset error prop for all actions
  improve ts typings
  README and ISSUE_TEMPLATE updated to reflect decision about 4.0.0-beta.x version (#3242)
  Add support for deprecated Tabs component (#3214)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aksonov aksonov aksonov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daviscabral @aksonov