Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration to react-navigation v2.x (#3068) #3141

Merged
merged 20 commits into from
Aug 8, 2018
Merged

migration to react-navigation v2.x (#3068) #3141

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
3bb4610
WIP: migration to react-navigation v2.x (#3068)
aksonov Jul 22, 2018
ab88a3b
upgrade Example to RN0.56
aksonov Jul 22, 2018
1fafbc5
revert RN to 0.55.4
aksonov Jul 22, 2018
1c386f5
use WIP RNRF for Example
aksonov Jul 22, 2018
49b8991
Babel v7, ESlint fixes, React/React Navigation upgrades, mobx removed…
daviscabral Jul 24, 2018
a512845
fix custom navigators
aksonov Jul 24, 2018
bf9cd0e
fix eslint
aksonov Jul 24, 2018
c8cac77
fix error
aksonov Jul 24, 2018
2fb9e1e
fix eslint errors
aksonov Jul 24, 2018
a532bec
more eslint fixes
aksonov Jul 24, 2018
89cde38
fix error
aksonov Jul 24, 2018
2c61904
fix eslint
aksonov Jul 24, 2018
e643ac6
add onEnter/onExit handlers and automatic transitions
aksonov Jul 25, 2018
a891195
fix navTransparent
aksonov Jul 25, 2018
3d2a97c
introduce onStateChange handler to be used instead of createReducer
aksonov Jul 25, 2018
1fd8796
bump version
aksonov Jul 25, 2018
aba39e3
small tweaks
aksonov Jul 25, 2018
e8085cd
Navigation and replace restored (#3147)
daviscabral Jul 26, 2018
8b58d15
fix Example
aksonov Jul 27, 2018
724ff44
Implement correct replace, popTo actions, restore reducer
Aug 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Example/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,16 @@
"mobx": "^3.2.1",
"mobx-react": "^4.2.1",
"prop-types": "^15.5.10",
"react": "16.4.1",
"react-native": "0.56.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to revert this here? Something that I might help? I was thinking about using the last version for everything. I've spent a couple of days in the past week just to make a few projects to work with these versions.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please try to fix. I've got some babel-related error, connected with stage 0 or something like that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool - I think I know how to fix them. This might be related to the use of babel 7 (I had to upgrade a few other deps in order to make it to work - checking it).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got example working with latest react and react-native.

ezgif-5-da09ec92f0

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also from:

✖ 538 problems (535 errors, 3 warnings)

To:

✖ 136 problems (133 errors, 3 warnings)

"react": "16.3.2",
"react-native": "0.55.4",
"react-native-button": "^2.0.0",
"react-native-message-bar": "^1.6.0",
"react-native-router-flux": "4.0.0-beta.32",
"react-native-router-flux": "github:aksonov/react-native-router-flux#3bb4610be19678b98959e59c1024bdc2c5806ecf",
"react-navigation": "^2.8.0"
},
"devDependencies": {
"babel-jest": "20.1.0-echo.1",
"babel-preset-react-native": "^5.0.1",
"babel-preset-react-native": "2.1.0",
"babel-preset-react-native-stage-0": "^1.0.1",
"jest": "20.1.0-echo.1",
"react-test-renderer": "16.3.2"
Expand Down
Loading