popTo causes an infinite loop when route is not found (as seen on #3026) #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviscabral
force-pushed
the
3026/dc/pop-to-causes-infinite-loop-when-route-is-not-found
branch
from
5eec2cb to
309b55a
Compare
|
@aksonov any objections about getting this merged? |
|
Strange, I didn't received any email about that, sorry. will review now |
Closed
daviscabral
deleted the
3026/dc/pop-to-causes-infinite-loop-when-route-is-not-found
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure about the solution here. Right now it is just assuming that it does not exist and returning to the top level route existent.
The problem with this approach is that might allow calls to inexistent routes pass unknown.
What do you think here guys?
AddKeep the warning about the unknown route;routeNamethat matches;Keep like it is in this PR,just redirects to the top level.(This PR is about the problem reported in #3026)