Add listeners to navigation (as part of react-navigation 1.0.0 breaking changes) #3032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on 1.0.0 breaking changes)
daviscabral
changed the title
|
Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After trying to work in a fix for a very old issue related to a misaligned title in the
NavBar- I really got bothered that I couldn't run theExampleproject - and also even use the most recent project.After a few hours digging in the code - noticed the missing listener in the
navigationprops. It still might have some bad side effects - since I am only forwarding the existent method to it.This PR might be the fix for #2897, #3006, #2976, #2865 and #3008.
EDIT: Also a few major/minor version updates of some packages (npm is still whining about lots of security issues -
npm auditto get a better report about it).