Component prop should be optional #2769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick fixes for typing errors on: error TS2411
|
I can approve it, but probably it is better to make component required for |
|
I see, you are absolutely right. I missed the |
|
Right, but shouldn't we deprecate the old syntax and update the docs to remove all the ? It's kind of confusing for typescript users |
|
@aksonov could you bump the version, please? |
mvanroon
pushed a commit
to mvanroon/react-native-router-flux
that referenced
this pull request
Feb 15, 2018
* Quick fixes for typing errors on: error TS2411 * Component should be optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interface SceneProps should have the component prop set to optional (?), because it won't build in typescript when using a Nested Scene for Tabs. The docs claim to have this prop as and (semi)-optional.