Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drawer fixed, faulty closeDrawer removed, androidBack support added #2745

Merged
merged 1 commit into from
Dec 29, 2017
Merged

Drawer fixed, faulty closeDrawer removed, androidBack support added #2745

merged 1 commit into from
Dec 29, 2017

Conversation

vibhavagarwal5
Copy link
Contributor

@vibhavagarwal5 vibhavagarwal5 commented Dec 28, 2017 •
edited
Loading

  • Drawer had an error, fixed it.
  • There was a closeDrawer command in DrawerContent.js which wasnt working so removed it
  • Android back wasn't supported so added that.
  • Before:
    screenshot_20171228-212206
  • Before:
    screenshot_20171228-212712
  • After:
    screenshot_20171228-212514
  • After:
    screenshot_20171228-212728

@vibhavagarwal5
Copy link
Contributor Author

@aksonov do check the request.
this solves many problem for beginners (Faced in the example app)

@aksonov aksonov merged commit 2843534 into aksonov:master Dec 29, 2017
mvanroon pushed a commit to mvanroon/react-native-router-flux that referenced this pull request Feb 15, 2018
@vibhavagarwal5 @mvanroon
drawer fixed and faulty closeDrawer removed (aksonov#2745)
d3ed0ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vibhavagarwal5 @aksonov